Use DMLOptions to bypass duplicate rule exceptions #1498
Conversation
|
@aheber |
|
@chininchu thanks for getting this in! It looks like you've discarded the "allOrNothing" flag. You should be able to add it to the DMLOptions instance and retest. Could you revert the changes to the other files? Feel free to submit them separately. The change to update Prettier version would be a great additional PR. |
dlrs/main/classes/RollupService.cls
Outdated
|
|
||
| // Bypass duplicate rules | ||
|
|
||
| // dmlOptions.duplicateRuleHeader.duplicateRuleBypassFlow = true; |
There was a problem hiding this comment.
Could you remove this extra comment?
|
|
||
| // Bypass duplicate rules | ||
|
|
||
|
|
||
| try { | ||
| return Database.update(masterRecords, allOrNothing); |
There was a problem hiding this comment.
@chininchu were you able to test this code in an environment? You've put it back the way it was and aren't including the DmlOptions anymore.
There was a problem hiding this comment.
Yes, I was able to test the code and it works. You should now see the DML options on my latest commit.
dlrs/main/classes/RollupService.cls
Outdated
| try { | ||
| return Database.update(masterRecords, allOrNothing); | ||
|
|
There was a problem hiding this comment.
Are these extra lines necessary?
| "typeAcquisition": { | ||
| "include": ["jest"] | ||
| } | ||
| "compilerOptions": { |
There was a problem hiding this comment.
This file is still showing modified in your PR. Please revert this change.
There was a problem hiding this comment.
This should be aligned with what's on the main branch.
| @@ -25,8 +25,8 @@ | |||
| "eslint-plugin-jest": "^24.7.0", | |||
| "husky": "^6.0.0", | |||
| "lint-staged": "^11.2.6", | |||
| "prettier": "^2.5.0", | |||
| "prettier-plugin-apex": "^1.10.0" | |||
| "prettier": "2.5.0", | |||
There was a problem hiding this comment.
This file is still showing modified in your PR. Please revert this change.
There was a problem hiding this comment.
This should be aligned with what's on the main branch.
@aheber, Please refer to my latest commit for changes. Thanks. |
Add Snowfakery schema into repo
…or ready to go testing.
…ged part of repo.
…ields into Section.
Add Snowfakery functionality to allow for low ratio testing on standard and custom objects.
Add logic to populate fields for Custom to Standard Rollups to work.
|
Superseded by #1502 |
Critical Changes
Changes
Issues Closed