Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change check permission strategy #1508

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Change check permission strategy #1508

merged 4 commits into from
Nov 25, 2024

Conversation

aheber
Copy link
Contributor

@aheber aheber commented Nov 25, 2024

Changes

  • improve custom permission check to work in packaged context

Issues Closed

#1507

@aheber
Copy link
Contributor Author

aheber commented Nov 25, 2024

@octatau the last PR wasn't quite right. I think this should help fix it out.

Ready for your review when you have some time. (no hurry)

@aheber aheber enabled auto-merge November 25, 2024 14:53
@aheber aheber requested a review from octatau November 25, 2024 14:53
@aheber aheber merged commit 7a40051 into main Nov 25, 2024
3 checks passed
@aheber aheber deleted the feature/1507-change-custom-permission-check branch November 25, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octatau octatau octatau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aheber @octatau