Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metecho UI changes to facilitate extraction of non source tracking component #2159

Merged
merged 27 commits into from
Feb 21, 2024

Conversation

lakshmi2506
Copy link
Contributor

W-14736707

To support retrieval of non-source-trackable changes, new attributes non_source_changes is created for the ScratchOrg and api scratch_org_listmetadata is created which calls the job to fetch the components.

get_nonsource_components is created to call the CCI task of ListComponents and these changes are fetched on expanding the panel corresponding the metadata_type in the UI. While the job is processing a spinnerwrapper is fetched over the modal.

After changes:

Screenshot 2024-02-02 at 5 09 54 PM Screenshot 2024-02-02 at 5 11 24 PM

@lakshmi2506 lakshmi2506 requested a review from a team as a code owner February 2, 2024 11:42
@lakshmi2506 lakshmi2506 requested a review from mgrandhi February 21, 2024 10:13
Copy link

@mgrandhi mgrandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments and ask @jkasturi-sf to review Python changes

src/js/components/tasks/retrieveMetadata/changes.tsx Outdated Show resolved Hide resolved
src/js/components/tasks/detail.tsx Show resolved Hide resolved
@lakshmi2506 lakshmi2506 requested a review from mgrandhi February 21, 2024 12:25
Copy link

@mgrandhi mgrandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jkasturi-sf jkasturi-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jkasturi-sf jkasturi-sf merged commit 0f011c2 into main Feb 21, 2024
6 checks passed
@jkasturi-sf jkasturi-sf deleted the feature/non-sourcetracking branch February 21, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants