Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): stub out information page, also fix icons #159

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

joni-f-g
Copy link

@joni-f-g joni-f-g commented Feb 1, 2023

A quick stub for Information Pages —

The structure of an Information Page is pretty simple, and this demonstrates that we basically already have the components we need for them. I'm holding off on building a more complex Image component until I have a good sense of the requirements. Images may end up just living in the NextJS side of things, in fact.

Also, I threw in a fix for images after we broke them in The Great Package Collapse 😛

@joni-f-g joni-f-g requested a review from shawnbot February 1, 2023 01:03
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-159 February 1, 2023 01:04 Inactive
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Size Change: +160 B (0%)

Total Size: 277 kB

Filename Size Change
dist/elements/index.js 28.7 kB +51 B (0%)
dist/elements/index.mjs 28.5 kB +50 B (0%)
dist/react/index.js 61.8 kB +13 B (0%)
dist/react/index.mjs 60.8 kB +46 B (0%)
ℹ️ View Unchanged
Filename Size
dist/css/base.css 273 B
dist/css/components.css 878 B
dist/css/fonts.css 170 B
dist/css/icons.css 140 B
dist/css/overrides.css 104 B
dist/css/sfds.css 48.3 kB
dist/css/typography.css 557 B
dist/css/utilities.css 46.7 kB

compressed-size-action

@joni-f-g joni-f-g temporarily deployed to sfgov-design-system-pr-159 February 1, 2023 01:10 Inactive
Copy link
Member

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@joni-f-g joni-f-g merged commit 80c3b0d into main Feb 8, 2023
@joni-f-g joni-f-g deleted the feat/info-page-stub branch February 8, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants