Use fixed version for CSFML #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXpl0it3r
reviewed
Jun 6, 2024
Marioalexsan
force-pushed
the
use-fixed-version
branch
from
7f5f56d
to
8f059f0
Compare
Marioalexsan
force-pushed
the
use-fixed-version
branch
from
8f059f0
to
936bb29
Compare
|
Tried to install a local package of SFML.Net 2.6 while having CSFML 2.5.2 installed:
Removed CSFML and updated SFML.Net to 2.6, then tried to install CSFML 2.5.2:
I guess, I could try to create a fake CSFML 2.7 package, but I think the system is solid enough. |
eXpl0it3r
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This theoretically prevents users from accidentally updating CSFML to a newer version from the NuGet Updates tab. It doesn't stop them from forcefully installing a newer version of CSFML as per https://learn.microsoft.com/en-us/nuget/concepts/dependency-resolution#direct-dependency-wins.