Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert GitHub Windows Image Workarounds #3090

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

eXpl0it3r
Copy link
Member

Description

Preparing a PR to revert #3076 for once GitHub fixes their GitHub Action Windows image:

How to test this PR?

CI should pass

@eXpl0it3r eXpl0it3r added this to the 3.0 milestone Jun 11, 2024
@eXpl0it3r eXpl0it3r force-pushed the bugfix/revert-github-image-workarounds branch from d4d1d4b to 0d3ee84 Compare June 11, 2024 13:43
@eXpl0it3r eXpl0it3r force-pushed the bugfix/revert-github-image-workarounds branch from 0d3ee84 to c59bb39 Compare June 12, 2024 07:17
@eXpl0it3r
Copy link
Member Author

Looks like they've started to slowly rollout fixed images. Some runs succeeded now, but I guess it will take another 1-2 days until it's fully rolled out.

@vittorioromeo
Copy link
Member

A newer version of llvm (v18.1.6) is already installed.
 Use --allow-downgrade or --force to attempt to upgrade to older versions.

Could we add --force as a stopgap measure to keep our CI working?

@eXpl0it3r
Copy link
Member Author

Looks like the image rollout is complete. I'll fix the analyzing warning that clang-tidy 18 revealed.

@coveralls
Copy link
Collaborator

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9478361351

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 188 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-4.6%) to 55.725%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/SFML/Window/Win32/JoystickImpl.cpp 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/SFML/Window/Win32/JoystickImpl.cpp 188 10.47%
Totals Coverage Status
Change from base Build 9465575196: -4.6%
Covered Lines: 11564
Relevant Lines: 19674

💛 - Coveralls

@ChrisThrasher ChrisThrasher merged commit da17ec4 into master Jun 12, 2024
201 of 205 checks passed
@ChrisThrasher ChrisThrasher deleted the bugfix/revert-github-image-workarounds branch June 12, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants