Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cost stamps #1745

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add cost stamps #1745

wants to merge 14 commits into from
+75 −4

Conversation

dmwever
Copy link
Contributor

@dmwever dmwever commented Jan 22, 2025

fixes #1676.

jere8184
jere8184 suggested changes Jan 22, 2025
View reviewed changes
libopenage/pathfinding/cost_field.h Outdated Show resolved Hide resolved
@dmwever dmwever requested a review from jere8184 January 23, 2025 22:17
heinezen
heinezen requested changes Jan 25, 2025
View reviewed changes
Copy link
Member

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good so far.

In addition to the fixes to the comments I made, you should also add unit tests for stamping and unstamping the cost field in tests.cpp.

libopenage/pathfinding/cost_field.cpp Outdated Show resolved Hide resolved
libopenage/pathfinding/cost_field.cpp Outdated Show resolved Hide resolved
libopenage/pathfinding/cost_field.cpp Outdated Show resolved Hide resolved
libopenage/pathfinding/cost_field.h Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heinezen heinezen heinezen requested changes

@jere8184 jere8184 jere8184 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cost stamps (pathfinder)
3 participants
@dmwever @heinezen @jere8184