-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove d_prototype
& create type tests for p_prototype
#104
Conversation
Does the version change to v0.2.0? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 98.09% 98.09% -0.01%
==========================================
Files 6 6
Lines 1415 1414 -1
==========================================
- Hits 1388 1387 -1
Misses 27 27 ☔ View full report in Codecov by Sentry. |
Yes - this is a breaking change, so we have to increment the leading non-zero digit of the version number. We should also add something like
to NEWS.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you please increment the version number and describe the changes in NEWS.md?
Co-authored-by: Hendrik Ranocha <[email protected]>
This should now be ready to merge. |
Thanks! I would like to merge #105 first, release a new version of PositiveIntegrators.jl, and merge this PR afterwards |
d_prototype
, see the discussion in Used_prototype
when solvingPDSProblem
s #99. In the algorithm caches we simply useD=similar(u)
etc. APDSFunction
still has a fieldd_protoype
which is initialized asd_protoype=similar(u0)
, but users cannot change this or passd_protoype
as a keyword to aPDSProblem
.P
s in the algorithm caches have the same type as a givenp_prototype
(only for in-place)