Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove d_prototype & create type tests for p_prototype #104

Merged
merged 7 commits into from
Jul 18, 2024

Conversation

SKopecz
Copy link
Owner

@SKopecz SKopecz commented Jul 17, 2024

  1. There is no need for a d_prototype, see the discussion in Use d_prototype when solving PDSProblems #99. In the algorithm caches we simply use D=similar(u) etc. A PDSFunction still has a field d_protoype which is initialized as d_protoype=similar(u0), but users cannot change this or pass d_protoype as a keyword to a PDSProblem.
  2. An additional test ensures that the Ps in the algorithm caches have the same type as a given p_prototype (only for in-place)

@SKopecz
Copy link
Owner Author

SKopecz commented Jul 17, 2024

Does the version change to v0.2.0?

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (258c798) to head (8a7bc3b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   98.09%   98.09%   -0.01%     
==========================================
  Files           6        6              
  Lines        1415     1414       -1     
==========================================
- Hits         1388     1387       -1     
  Misses         27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SKopecz SKopecz requested a review from ranocha July 17, 2024 20:48
@ranocha
Copy link
Collaborator

ranocha commented Jul 18, 2024

Does the version change to v0.2.0?

Yes - this is a breaking change, so we have to increment the leading non-zero digit of the version number. We should also add something like

## Changes when updating to v0.2 from v0.1.x

#### Added

#### Changed

#### Deprecated

#### Removed

- The optional keyword argument `d_prototype` has been removed from `PDSProblem`

to NEWS.md

Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please increment the version number and describe the changes in NEWS.md?

test/runtests.jl Outdated Show resolved Hide resolved
@SKopecz
Copy link
Owner Author

SKopecz commented Jul 18, 2024

This should now be ready to merge.

@ranocha
Copy link
Collaborator

ranocha commented Jul 18, 2024

Thanks! I would like to merge #105 first, release a new version of PositiveIntegrators.jl, and merge this PR afterwards

@ranocha ranocha merged commit f86c263 into main Jul 18, 2024
9 checks passed
@ranocha ranocha deleted the sk/remove-d_prototype branch July 18, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants