Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement get_tmp_cache #113

Merged
merged 4 commits into from
Jul 28, 2024
Merged

implement get_tmp_cache #113

merged 4 commits into from
Jul 28, 2024

Conversation

ranocha
Copy link
Collaborator

@ranocha ranocha commented Jul 24, 2024

This function is required for some interoperability with Trixi.jl.

CC @jmbender

@ranocha ranocha requested a review from SKopecz July 24, 2024 11:28
src/mprk.jl Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (6845b50) to head (787d8a5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files           6        6           
  Lines        1414     1420    +6     
=======================================
+ Hits         1387     1393    +6     
  Misses         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha
Copy link
Collaborator Author

ranocha commented Jul 24, 2024

Do you understand the error below, @SKopecz?

┌ Error: failed to run `@example` block in src/index.md:173-178
│ ```@example SIR
│ using Plots
│ 
│ plot(sol, label = ["S" "I" "R"], legend=:right)
│ plot!(sol, idxs = ((t, S, I, R) -> (t, S + I + R), 0, 1, 2, 3), label = "S+I+R") #Plot S+I+R over time.
│ ```
│   exception =
│    Incorrect specification of `idxs`

I have not changed this part of the docs and it worked before...

Copy link
Contributor

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you understand the error below

I'm not sure, but I could imagine this comes from SciML/SciMLBase.jl#645.

test/runtests.jl Outdated Show resolved Hide resolved
@JoshuaLampert
Copy link
Contributor

You could test that by forcing [email protected].

Co-authored-by: Joshua Lampert <[email protected]>
@ranocha ranocha mentioned this pull request Jul 24, 2024
@ranocha
Copy link
Collaborator Author

ranocha commented Jul 24, 2024

Good idea. It's running in #114

@ranocha
Copy link
Collaborator Author

ranocha commented Jul 24, 2024

Yes, that's the issue: SciML/SciMLBase.jl#746

@ranocha
Copy link
Collaborator Author

ranocha commented Jul 25, 2024

Re-running CI so that we can check the results with the latest version of SciML including a bug fix.

@ranocha
Copy link
Collaborator Author

ranocha commented Jul 25, 2024

No, didn't help...

@SKopecz
Copy link
Owner

SKopecz commented Jul 26, 2024

I'd suggest to discard the line plot!(sol, idxs = ((t, S, I, R) -> (t, S + I + R), 0, 1, 2, 3), label = "S+I+R") in the docs. I find the syntax idxs = ((t, S, I, R) -> (t, S + I + R), 0, 1, 2, 3) rather cumbersome. Instead we could use something like

plot!(sol.t,sum.(sol.u), label = "S+I+R")

@ranocha
Copy link
Collaborator Author

ranocha commented Jul 27, 2024

I'd suggest to discard the line plot!(sol, idxs = ((t, S, I, R) -> (t, S + I + R), 0, 1, 2, 3), label = "S+I+R") in the docs. I find the syntax idxs = ((t, S, I, R) -> (t, S + I + R), 0, 1, 2, 3) rather cumbersome. Instead we could use something like

plot!(sol.t,sum.(sol.u), label = "S+I+R")

Done in 787d8a5

@SKopecz SKopecz merged commit 38d69d8 into main Jul 28, 2024
12 checks passed
@SKopecz SKopecz deleted the hr/get_tmp_cache branch July 28, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants