Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of get_fsalfirstlast for MPRK schemes #119

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

SKopecz
Copy link
Owner

@SKopecz SKopecz commented Aug 26, 2024

Due to a change in OrdinaryDiffEq in-place problems cannot be solved currently.

solve(prob_pds_linmod_inplace, MPE(); dt=0.1)

ERROR: MethodError: no method matching get_fsalfirstlast(::MPEConservativeCache{…}, ::Vector{…})

@SKopecz
Copy link
Owner Author

SKopecz commented Aug 26, 2024

To solve the problem, I tried something similar to https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/lib/OrdinaryDiffEqRKN/src/rkn_caches.jl. But it doesn't work.

@ranocha What am I doing wrong? How do we solve this problem?

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (719311e) to head (b3682ac).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files           7        7           
  Lines        1537     1538    +1     
=======================================
+ Hits         1510     1511    +1     
  Misses         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SKopecz
Copy link
Owner Author

SKopecz commented Aug 27, 2024

@ranocha Found the problem. I didn't import get_fsalfirstlast from OrdinaryDiffEq.

@SKopecz SKopecz requested a review from ranocha August 27, 2024 07:03
Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@ranocha ranocha merged commit e06c7f5 into main Aug 27, 2024
12 checks passed
@ranocha ranocha deleted the sk/fsalfirstlast branch August 27, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants