Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Validation feeback #128

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

bobot
Copy link
Contributor

@bobot bobot commented Aug 9, 2024

No description provided.

@bobot
Copy link
Contributor Author

bobot commented Aug 9, 2024

@Gbury You can be interested in taking a look at this little model verification summary. also @martinjonas @mbromber

@bobot bobot force-pushed the fix_largest_contribution branch from 241fef7 to 6f098e0 Compare August 9, 2024 14:04
@Gbury
Copy link

Gbury commented Aug 9, 2024

Very interesting.

The ite problem can be resolved fairly easily (actually, I think it should already be lazy, because you need that for recursive fonctions, but I may misremember), but as you point out, similar problems may arise with implications, and maybe other functions in the future, so I think we need some kind of specification in the standard of which functions are expected to be evaluated lazily.

Hopefully, with the new printing capabilities of Dolmen, I'll try to "fix" the problems in the SMT-LIB that do not respect the standard, so that new year it can be fully compliant (fingers crossed, ^^).

@bobot bobot force-pushed the fix_largest_contribution branch from 6f098e0 to 02232bf Compare August 11, 2024 08:17
@bobot bobot merged commit 279d242 into SMT-COMP:master Aug 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants