[Feat/#50] "회원가입 > 1. 프로필 선택, 2. 닉네임 입력" UI를 구현합니다. #57
Conversation
…ID-GONGBAEK into feat-#50-onboarding-ui
| ) | ||
|
|
||
| GongBaekBasicButton( | ||
| title = "다음", |
There was a problem hiding this comment.
[3] : string 추출은 어떠신가용
| Column { | ||
| StartTitleTopBar(onClick = onBackClick) | ||
|
|
||
| GongBaekProgressBar(progressPercent = 0.285f) |
There was a problem hiding this comment.
[3]: percent가 화면 수치에 맞지 않는 것 같습니다 ! (화면이 8개라 0.125 배수로 설정하시면 될듯용)
| ) | ||
|
|
||
| GongBaekBasicButton( | ||
| title = "다음", |
There was a problem hiding this comment.
[3]: 위에서 추출한거 또 쓸 수 잇겟네요 !
| ImageSelectorSection( | ||
| modifier = Modifier | ||
| .padding(horizontal = 16.dp) | ||
| .align(Alignment.TopCenter), | ||
| selectedProfileIndex = selectedProfile, | ||
| onIndexSelected = onSelectedProfile | ||
| ) |
There was a problem hiding this comment.
[3]: 아예 위에 부분은 섹션으로 묶는거 좋네요 ! 참고하겠습니다 !
| data class UserInfo( | ||
| val profileImage: Int?, | ||
| val nickname: String, | ||
| val mbti: String, | ||
| val schoolName: String, | ||
| val schoolMajor: String, | ||
| val schoolGrade: Int?, | ||
| val enterYear: Int?, | ||
| val introduction: String, | ||
| val sex: String, | ||
| val timeTable: TimeTable | ||
| ) |
There was a problem hiding this comment.
[3] 네이밍에 대한 이야기인데요, 모집자 프로필 모델과 컨벤션을 맞춰서
schoolName -> school
schoolMajor -> major
schoolGrade -> grade
sex -> gender
로 변경은 어떤지 건의드리고 싶습니다!
| fun NavController.navigateAuthRoute() { | ||
| navigate(route = NavigationRoute.AuthNavGraphRoute.AUTH_NAV_GRAPH) | ||
| } | ||
|
|
||
| fun NavController.navigateCompleteAuth() { | ||
| navigate(route = NavigationRoute.AuthNavGraphRoute.AUTH) | ||
| } | ||
|
|
||
| fun NavController.navigateNickname() = navigate(route = NavigationRoute.AuthNavGraphRoute.NICKNAME) | ||
|
|
||
| fun NavController.navigateUnivMajor() = navigate(route = NavigationRoute.AuthNavGraphRoute.UNIV_MAJOR) |
There was a problem hiding this comment.
[3] 위아래 둘 중 하나의 방식으로 컨벤션을 맞추는게 통일성이 있을것 같습니다!
| NicknameRoute( | ||
| viewModel = viewModel, | ||
| navigateUnivMajor = navController::navigateUnivMajor, | ||
| naviToBack = navController::popBackStack |
There was a problem hiding this comment.
[3] 다른 navigate 함수와 비슷하게 navigateBack 네이밍은 어떨까요!
| data class OnProfileImageChanged(val profileImage: Int?) : Event() | ||
| data class OnNicknameChanged(val nickname: String) : Event() |
There was a problem hiding this comment.
[3] Changed는 기존의 정보가 변경되는 느낌이 강한데, 아직 정해진 정보가 없는 상황에서 사용자가 고르는 화면이니 onProfileImageSelected 라는 네이밍은 어떨까요?
| sealed interface SideEffect : UiSideEffect { | ||
| data object NavigateToBack : SideEffect | ||
| data object NavigateToNickname : SideEffect | ||
| } | ||
| } |
There was a problem hiding this comment.
[2] navigate 함수와 네이밍 컨벤션 맞춰서 To는 삭제해도 좋을 것 같습니다
| } | ||
|
|
||
| @Composable | ||
| private fun NickNameInputSection( |
There was a problem hiding this comment.
[3] NickName -> Nickname이 좋을것 같습니다!
Related issue 🛠
Work Description ✏️
Screenshot 📸
auth1.mp4
Uncompleted Tasks 😅
To Reviewers 📢