Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STYLE] 헤더 요구사항 반영 #119

Merged
merged 2 commits into from
Nov 30, 2024
Merged

[STYLE] 헤더 요구사항 반영 #119

merged 2 commits into from
Nov 30, 2024

Conversation

yarimu
Copy link
Collaborator

@yarimu yarimu commented Nov 29, 2024

관련 이슈 🛰️

해결한 이슈 번호를 작성해주세요
close #104

작업 내용 🧑‍💻

작업한 내용을 간략히 작성해주세요

  • 오늘 qa 반영했습니다!

PR 포인트 🗯️

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • 화면의 크기가 달라져도 요소 사이의 gap이 고정되었으면 좋겠다는 의견에따라,
    중앙정렬 후, gap을 추가했습니당!
  • 깃 관리 모대서 죄송합니다..
  • 세미나까지 아이텀 설치해갈게유...

스크린샷 📸 (선택)

2024-11-29.7.31.23.mov

@yarimu yarimu self-assigned this Nov 29, 2024
Copy link
Collaborator

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seong-hui seong-hui merged commit 58d8c5b into develop Nov 30, 2024
2 checks passed
@seong-hui seong-hui deleted the feat/#104/favicon-og branch November 30, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 파비콘, OG태그 이미지 적용
2 participants