Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Races port #1056

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Races port #1056

wants to merge 4 commits into from

Conversation

Comicao1
Copy link

About The Pull Request

finishes porting Diona's mentioned in a previous issue.

Why It's Good For The Game

MORE SPECIES!!

A Port?

Yes and No, it's based on Vore's diona.

Pre-Merge Checklist

  • [ yes ] You tested this on a local server.
  • [ yes ] This code did not runtime during testing.
  • [ yes ] You documented all of your changes.

Changelog

add: DIONA
add: max age is now based on species, just so diona can have 300 years
add: two diona skillss
add: diona nymphs and evolution
fixes vox mistake i commited before
🆑
add: Added new things
add: Added more things
del: Removed old things
tweak: tweaked a few things
balance: rebalanced something
fix: fixed a few things
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
imageadd: added some icons and images
imagedel: deleted some icons and images
spellcheck: fixed a few typos
code: changed some code
refactor: refactored some code
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
wip: still being worked on
experiment: experimental
tgs: has something to do with tgs
expansion: expands on something
qol: quality of life content
/:cl:

@ariaworld
Copy link

ariaworld commented Jan 13, 2024

Not sure about the species age limitation because some people make characters 1.000.000 years old
could also use span_notice (and for other span_ class) for cleaner text, writing <span class="notice"> is a bit less clean

@Yawet330
Copy link

Not sure about the species age limitation because some people make characters 1.000.000 years old could also use span_notice (and for other span_ class) for cleaner text, writing <span class="notice"> is a bit less clean
this is a vorecode port, it was guaranteed to have awful coding practice.

Copy link

@Yawet330 Yawet330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awful 1:1 port.

Fix it.

set category = "Abilities"

if(nutrition < 250)
to_chat(src, "<span class='warning'>You lack the biomass to begin regeneration!</span>")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to_chat(src, span_warning("You lack the biomass to begin regeneration!"))

//flesh_color = "#808D11"

min_age = 1
max_age = 300

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefine min_age and max_age, as 1 would be below 18 (our minimum age) for species.

I don't care if they can't have genitals due to the fact you forgot to do ANY adjustment; we do not allow people with characters below the age of 18 on the server.

return

if(active_regen)
to_chat(src, "<span class='warning'>You are already regenerating tissue!</span>")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

span_warning("text")

return
else
active_regen = TRUE
src.visible_message("<span class='filter_notice'><B>[src]</B>'s flesh begins to mend...</span>")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

span_notice("text")


active_regen = FALSE
else
to_chat(src, "<span class='critical'>Your regeneration is interrupted!</span>")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

span_userdanger("text")

if(mind)
mind.transfer_to(S)

message_admins("\The [src] has split into nymphs; player now controls [key_name_admin(S)]")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this admin-logged?

for(var/obj/item/W in src)
dropItemToGround(W)

visible_message("<span class='warning'>\The [src] quivers slightly, then splits apart with a wet slithering noise.</span>")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

span_warning("text")

add_language(LANGUAGE_GALCOM)
verbs += /mob/living/carbon/alien/diona/proc/merge

/mob/living/carbon/alien/diona/get_available_emotes()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all of this code ffs

Copy link

@MosleyTheMalO MosleyTheMalO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the requested changes and remove the age edits

@MosleyTheMalO
Copy link

Please don't just update the minimum age, remove the changes related to age entirely because they'll just cause confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants