Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ferals #1139

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

lpeapnni
Copy link

@lpeapnni lpeapnni commented Apr 13, 2024

About The Pull Request

Ports the feral creature system from Coyote Bayou, along with many of its species. Also claims the bounty here: #1112
image

Why It's Good For The Game

More player customization and roleplay options.

A Port?

Ports most of the stuff added here: ARF-SS13/coyote-bayou#3818

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
add: Ports feral creatures from Coyote Bayou
/:cl:

Copy link

@liz-lavenza liz-lavenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of how this feature is implemented, particularly the large number of core code edits all throughout the human icon/HUD update chain, but I don't know if there's really a better way to go about it on this codebase. I'll take another look once my specific comments have been addressed.

@nfrontiers
Copy link

You are Oppenheimer, as I am Franklin Roosevelt. This, is the Manhattan Project.

@blackcrystall
Copy link

blackcrystall commented Apr 26, 2024

I am not a fan of how this feature is implemented, particularly the large number of core code edits all throughout the human icon/HUD update chain, but I don't know if there's really a better way to go about it on this codebase. I'll take another look once my specific comments have been addressed.

WARNING: it's my PERSONAL and only personal opinion for my personal use, just what I think about it and I don't want to insult anybody or do something like that, I'm not toxic or trying to be, just saying out my personal opinion on this PR. (English is not my native language, so if I said something very wrong and toxic, I'm sorry)
MARK: I found this PR randomly, working with other downstream project, this just hit my view and I checked it out, because rn I working on something like that. (overkill for one bounty... litteraly overkill)

(this bounty probably don't mean just port, so. . . yea, it's cringe for 150$)

There exist other way harder, a lot harder rather than just doing "port" of low quaility shtode. . .

This one. . . is. . . ah, time to do review, idk what devs here think about third party review (good quaility ones) on prs, probably I will do it, if maintainers willing to accept it as "fine". (not a lot of code to strike down here, but. . . I can try)

For 150$ he did this (just port, of shitcode!!!). . . it's, Ye, doing full rework of human mechanics and doing it in good way, it's hard, for this amount of money alot of work, that do not cost it small, but. . . instead he did this, litteraly nothing.

(sorry for using a lot of " . . . ", nothing to say, only emotions)
Conclusion (my personal opinion, as a suggestion.):
Reject this bad bounty hunter and let someone else take this bounty, at least make this guy do real job for 150$ with coding nice system, not shtcode that ported for ?20 mins (or faster)? of work.

One more time sorry for this personal opinion in comment section for this PR, I can't hold it back

@MysteryMan21333
Copy link

I'd prefer if you remove all the IRL species that can be played as ferals and make the pokemon just simple mobs. But feel free to add any of the many other mobs as part of this system.

@SaraSayomi
Copy link

I'd prefer if you remove all the IRL species that can be played as ferals and make the pokemon just simple mobs. But feel free to add any of the many other mobs as part of this system.

Personally I prefer the IRL animals remain, we are hopefully all intelligent enough adults to separate fantasy and reality, and it's not like you can't already turn into a simple mob animal like a corgi and get your fuck on. This PR is equal to the baulders gate bear scene in terms of spice to me, aka, not much, considering you can do everything a biped can, including talk and consent, which is more than current server rules require. In short, we're adults, let us be ourselves in a game where snuff, rape, and murder happens, we know how to not do the bad irl, don't go all tg and start removing anything you dislike even if others do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants