Emote Refractoring #1204
Merged
Emote Refractoring #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ab2ff17.
SPLURT maintainers try not to fuck up code challenge (impossible!) If you're gonna edit someone else's code, at least understand what you're editing please!
Why is *help so big... Also got rid of The Great SPLURT fart library.
oops silly me haha i accidentally left these sound files on my repo
might as well update while I'm at it
Reverts changes to *meow, *mrrp
Why are these global variables but you handled emote lists as E.emote_list?? you call them once and never again!!!
adjusted cooldown
Emote Purge & Merges
This Commit does the following: Ports the Emote Panel Turns SPLURT's emotes into /sound/human datums to reduce redundancy in the amount of emotes. Gives almost every emote a name for the emote panel. Removes herobrine. Also fixes a few errors and makes sure all files are properly tested for Pull Request
[PORT] Modern TG Emote Panel
silicons can now use the emote panel
Just-Sim
reviewed
Oct 8, 2024
| @@ -1,3 +1,31 @@ | |||
| /* SPLURT STATION Guide: | |||
…lls? AKA [PORT] Refactors smiting, adds smite build mode tgstation/tgstation#55327 !! NOT!! A!! RUNNING!! BUILD!! LIGHTNING IS BROKEN IMMERSE IS COMMENTED OUT HALF OF THIS SHIT IS BROKEN DO NOT BASE YOURSELF ON THIS BUILD!!
faster aheals faster tickets this one's coded by me Context Menu is ordered by category so switching it to Debug bumps it up a few spaces.
Please roleplay appropriately, okay? Commit can also be called "How I Lost My Entire Playerbase"
anthro facial hair fix
Popups, Smites, Immersion, Rejuvenation & the Ocky Icky
by the way, the comments are used to tell edits to nonmodular code apart from regular nonmodular code, not for crediting
Test Merge Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Refractors some emote code and functions, and also adds the emote panel to the game.
Also undoes some unnecessary edits from the previous port
Why It's Good For The Game
A Port?
From venus. Made mostly by @Just-Sim
Pre-Merge Checklist
Changelog
🆑
add: adds the emote panel using tgui
code: refractors emote code
/:cl: