Separate quirk code into individual files #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does the following: - Separates all modular quirks into separate files, with no other changes. - Modularizes some non-modular edits into a new file - Fixes location of hydra trait definition
Modularizes the edits to Sandstorm's quirk Sheltered
Removes a mistakenly added reference to a new-codebase quirk.
Adds missing trailing newlines to two quirk files.
Moves Sanguine Metabolism to a separate file to match new formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Separates modular quirk code from good, neutral, and negative files into distinct files per quirk. In addition, this properly modularizes edits made to upstream quirks. A new file (trait_edits.dm) contains the minor formally non-modular edits.
This does not change or fix anything else about the quirks. They are transferred as-is.
Why It's Good For The Game
Reduces the chance of merge conflicts when multiple pull requests edit quirks, and improves parity with modern TG. Modularizing edits makes it easier to determine what was changed.
A Port?
No, but inspired by tgstation PR #78407.
Pre-Merge Checklist
Changelog
🆑
code: Modular quirks are now in separate files
code: Modularized edits to upstream quirks
/:cl: