Lucky's second first PR #1227
Merged
Lucky's second first PR #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Merge Removed |
Mostly did this so I could learn how.
|
oops... anyhow, I also added the centcom uniform at /obj/item/clothing/under/rank/centcom. It now can be reskinned with alt-click! Added some last minute fixes, probably shoulda done that in a new PR. |
Test Merge Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This is a small, baby steps pull request by me. It is my first ever pull request, my first time uploading to GitHub and my first time coding with BYOND. I was curious about contributing and now I'm getting hands on experience. I think that's the biggest benefit of this PR.
This PR adds a new language for feline characters (Nyanese), a new title for captains (Catpain) and a new junkfood item (Sunflower Seeds) which can be grabbed at any snack vendor.
Most of the code is just copies and reskins of other code, so there's very little risk of breaking anything.
Additionally, I edited the BUILD batch file, requiring someone to press a key before the batch file closes, this was done because the file used to auto close before I could read all the errors during the coding process.(REMOVED)This is my first time ever doing any of this, so please feel free to reach out with pointers. I'm Karro "Lucky" Glowrra on the Splurt Discord.
12/6/24 UPDATE
Due to my poor understanding of github, some stuff I was working on and completed after had to be merged into this PR.
Sorry for the sporadic additions, I'm still learning github!
Why It's Good For The Game
This is a relatively minor PR so the effects on the game will be minimal, minimal but positive.
A new language will allow players to better express themselves and their character concepts, a new title will let captain players have another choice of expression and a new snack vending machine item will slightly increase the longevity of vending machines before they need to be restocked, while not making the chef obsolete.
In addition, having my first PR implemented would do wonders for my morale and push me to continue coding and contributing! It'd be a great first step.
12/6/24 UPDATE
The mask allows for more character customization while the emote lets players express themselves in a silly way.
A Port?
No.
Pre-Merge Checklist
Changelog
🆑
add: Old Glory sunflower seeds, a junk food available in snack machines.
add: "Catpain" title for Captain job.
add: Nyanese (feline) language.
add: TSC gasmask, available in sci wardrobe vendors. Slightly better bio and acid protection at the cost of rad protection.
add: "I blew up Malaysia" emote, 2 second cooldown.
/:cl: