Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mulebot fix #1231

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Mulebot fix #1231

wants to merge 6 commits into from

Conversation

Erbot34567
Copy link

@Erbot34567 Erbot34567 commented Dec 10, 2024

About The Pull Request

Fixes MULEbot's interface for both organics and silicons, PDA and BotKeeper control and handling of riding mobs

Why It's Good For The Game

It fixes MULEbots, which is another way for cargo to deliver things and have fun

AverageMULEbotActivity

[Don't try this at home]

A Port?

No

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
fix: MULEbot's interface buttons have been fixed
fix: MULEbot's PDA and BotKeeper control now functions as intended
fix: Mobs now don't merge with MULEbot visually
rscadd: MULEbots can now (partially) go up and down stairs
/:cl:

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Deployed

Details
Server Instance

SPLURT

Revision

Origin: 4544f91
Pull Request: 4e1c132
Server: 3722518e34f553a0ced4b65c0ddb08704dd2a5a9

Comment

@SaraSayomi
Copy link

As a note mulebots still break on multi-z, they will go up or down stairs and become useless.

@Erbot34567
Copy link
Author

As a note mulebots still break on multi-z, they will go up or down stairs and become useless.

Alright, I'll try to find solution for that

@SaraSayomi
Copy link

As a note mulebots still break on multi-z, they will go up or down stairs and become useless.

Alright, I'll try to find solution for that

If not no big deal, just figured mentioning it to someone who understands the code for them it might be an easy fix, and no one knows a problem until they get told after all.

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 2de8791
Pull Request: 4e1c132
Server: 553221170c040f9400d7a0cc873f706046cc9032

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: c6bc867
Pull Request: 4e1c132
Server: d1b9846c8f6cbea7e1bb49569656da8c16836123

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 658d653
Pull Request: 4e1c132
Server: ec9dbb41aa4cdcec0a3cbb02a62956a2c2cfb9f7

Comment

@Erbot34567
Copy link
Author

Managed to somehow implement some sort of transportation between Z-levels. It works fine if mulebot goes down but it is kinda tricky when it wants to go up and most probably it is going to be reworked. Anyway it can also partially "avoid" stairs but that also needs to be reworked. I'll appreciate any tips on how to make code better since I'm still learning DM.

@Erbot34567
Copy link
Author

As a note mulebots still break on multi-z, they will go up or down stairs and become useless.

Alright, I'll try to find solution for that

If not no big deal, just figured mentioning it to someone who understands the code for them it might be an easy fix, and no one knows a problem until they get told after all.

MULEbots can move between Z-levels and "avoid" stairs now.

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: cd0230f
Pull Request: 4e1c132
Server: c255de401a5d7553fabb0ca4a9aaacc2c31fd904

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: cd0230f
Pull Request: bc4986c
Server: 85ec44b0b9539294290d39bc3a3cd44b79049ae4

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: f89d73f
Pull Request: bc4986c
Server: 6741838cdcb59b90f93f44e794d6fe50849a1593

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: f89d73f
Pull Request: bc4986c
Server: e4a8baaed228b3b757b7f9f62129ed0721c4e6df

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: d931db8
Pull Request: bc4986c
Server: 30166cdd2f48040289f45e196499a696c0d51462

Comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants