Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMI-MODULAR] The CyberSun Shall Rise! #967

Closed

Conversation

MysteryMan21333
Copy link

@MysteryMan21333 MysteryMan21333 commented Oct 2, 2023

About The Pull Request

Good afternoon, ladies and gentlemen, I have brought you the Cybersun! But you may ask, well mystery what is the Cybersun? Well this is a import from TG about a Syndicate Ghost Role, where you play as one of the five crew onboard a lost ship deep in the fringes of the frontier, fortunately they've docked to a outpost! Unfortunate their being boarded a Nanotrasen Elite Assault Unit. Clear, Secure, and Defend your ship from outside interference using what you have on hand from a nearby syndicate outpost. However, you must also be on the lookout for it appears you have also been landed close to a Nanotrasen Facility nearby, keep your distance and explore the local space system for potential gear and utilities if you must, do not under any circumstances attempt to board or interact with crew on the nearby facility. If your approached by one of them near your ship, you have full liberty to detain or exchange pleasantries.

Transcription Log Begin...

This is Captain #####, of the SCSBC-11; The date is 8/21/2### and time of departure 11:47 PM. The crew and I will be in transit to a syndicate outpost in a nearby system to begin routine operations as instructed by Cybersun High Command. Were expected to eliminate a HVT in transit to a Nanotrasen facility, we'll make sure that convoy never makes it there...

This is Captain #####, of the SCSBC-12; The date is 8/23/2### and time of departure 7:34 AM. High command was quite pleased with our last mission in successfully dispatching a fleet of Nanotrasen vessels and eliminating a high profile target. As a result we now operate a newly designed and experimental ship. Including a bunch of new gear they've been rolling out from a experimental hardsuit design supposedly useful in combat, to a new vendor useful for giving us uniforms for the occasions, and a new set of assault rifles recently produced by Paradeus. These shall greatly increase our chance of success in the mission, doubt anyone's gonna wanna get hit by .543 caliber...

This is Captain #####, of the SCSBC-12; The date is 8/30/2### and time of departure 6:00 PM. We've been instructed by Cybersun High Command to proceed to a outpost location on the depths of the frontier, instructions were made to deliver highly sensitive documents on the movement and locations of further Nanotrasen facilities on the frontier. The crew are a bit nervous of the idea as its a incredibly long way out, but I'm sure with some nice rest in the cryopods we'll be there in no time. Ill be staying awake for a moment as I noticed some glitches appearing on our ships main navigation console, going to attempt contact with Cybersun High Command.

This is Captain #####, of the SCSBC-12; The date is 8/30/2### and time of departure 7:47 PM. Dear god, the entire system is fucked, we were struck by a unknown anomaly in our systems, the rest of the crew is still asleep in their pods, I've attempted to contact for emergency services. No dice, were stranded and perpetually floating through space, hopefully towards our destination the system isn't responding to any input or commands I've inserted, I think we were sabotaged, but who could've done this? One of my crew? Nanotrasen? High Command? I don't know but all I can do is put the ship into emergency power, keep my operatives on ice, and hopefully pick up a signal for the ship to catch onto. I'm going to slip into cryo, I don't know what's going to happen but Id rather die in my sleep then die by starvation...

Transcription Log End...

Includes:

  • Lore (For all those interested)!
  • A new space antagonist ghost role!
  • A new hardsuit!
  • A new gun! (Code and icons courtesy of @Vhariik)
  • Local Syndicate Comms, no needing to making symbols!
  • Plenty of gear to setup your ship without too much hassle!
  • Syndi-drobe (Essentially a syndicate wardrobe)!
  • And much more!

P.S. (I want this to be said ahead of time, if this PR does get merged, continue to follow the rules of the server, dont take this role as a means to go do what you want as a antagonistic faction, play in good faith. In terms of additional things to say, sadly I don't believe the hardsuit may work with taur and specific species yet, but they do work with digi-legs, Ill do some hotfixes later if needed. If you see a bug or think in some way the ship can be improved feel free to make a comment in the Issues section on the discord!)

The Map
image_2023-10-26_101358728

Why It's Good For The Game

Adds a new role to the space antagonist which is equivalent to the Syndicate Listening Outpost in a way. It also adds a form of survival as crew of the Cybersun need to find ways to live out in the harsh environment their in.

A Port?

Its a port of most of EgorDinamit design choices.
tgstation/tgstation#49349
Cybersun Comms
Skyrat-SS13/Skyrat-tg#2947
Cybersun Redesign
Skyrat-SS13/Skyrat-tg#2888
Syndi-drobe (Only, no interdyne included)
Skyrat-SS13/Skyrat-tg#4373

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
add: Adds a new antagonist ghost role.
soundadd: added a few new sounds.
expansion: expands on the space exploration.
/:cl:

# About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! -->
<!-- If your PR is related to one of our discord suggestions, please add the number of this suggestion to this section. Or if you may, the message link of said suggestion-->

## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. -->

## A Port?

<!-- Just say if it is a port of something and link the original pr/commit/whatever. -->

## Pre-Merge Checklist
<!-- Don't bother filling these in while creating your Pull Request, just click the checkboxes after the Pull Request is opened and you are redirected to the page. -->
- [ ] You tested this on a local server.
- [ ] This code did not runtime during testing.
- [ ] You documented all of your changes.
<!-- Neither the compiler nor workflow checks are perfect at detecting runtimes and errors. It is important to test your code/feature/fix locally. -->

## Changelog

:cl:
add: Added new things
add: Added more things
del: Removed old things
tweak: tweaked a few things
balance: rebalanced something
fix: fixed a few things
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
imageadd: added some icons and images
imagedel: deleted some icons and images
spellcheck: fixed a few typos
code: changed some code
refactor: refactored some code
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
wip: still being worked on
experiment: experimental
tgs: has something to do with tgs
expansion: expands on something
qol: quality of life content
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
@MysteryMan21333 MysteryMan21333 marked this pull request as ready for review October 2, 2023 20:50
@MysteryMan21333 MysteryMan21333 changed the title The CyberSun Shall Rise! [SEMI-MODULAR] The CyberSun Shall Rise! Oct 2, 2023
Copy link

@MosleyTheMalO MosleyTheMalO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alongside the code changes, I believe whatever classes can be modularized can also have their sprites be modularized too

code/game/objects/items/cards_ids.dm Outdated Show resolved Hide resolved
code/__DEFINES/role_preferences.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/radio/headset.dm Outdated Show resolved Hide resolved
code/game/objects/structures/ghost_role_spawners.dm Outdated Show resolved Hide resolved
code/modules/clothing/spacesuits/hardsuit.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/corpse.dm Outdated Show resolved Hide resolved
code/modules/ruins/spaceruin_code/forgottenship.dm Outdated Show resolved Hide resolved
@Yawet330
Copy link

Yawet330 commented Oct 5, 2023

This will cause issues balancewise and station-wise.
Not recommended to merge this in any permanent fashion without a few weeks of TMing, we don't need another golem-xenoarch incident that forces us to change the rules to be absolutely 'no-fun'.

@MysteryMan21333
Copy link
Author

MysteryMan21333 commented Oct 8, 2023

This will cause issues balancewise and station-wise. Not recommended to merge this in any permanent fashion without a few weeks of TMing, we don't need another golem-xenoarch incident that forces us to change the rules to be absolutely 'no-fun'.

As I said in the PR, this doesn't mean any specific rule changes, this is exactly like how you would treat the Syndicate Listening Station, except while they are able to leave their ship for supplies, it should be stated they are to not interact with the crew on station unless they themselves are being interacted in space; either in a aggressive or passive stance. They should not under any circumstances leave the confines of space to mess with the crew onboard the station or in anyway attempt to board the station.

code/modules/uplink/uplink_items/uplink_clothing.dm Outdated Show resolved Hide resolved
icons/mob/clothing/head.dmi Outdated Show resolved Hide resolved
@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Deployed

Details
Server Instance

SPLURT

Revision

Origin: 172f5f5
Pull Request: 3f67c17
Server: f1c2725640415a330e9db3f1da0a3004a8c5e3df

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 172f5f5
Pull Request: 3f67c17
Server: 8a324244574993fecd277613ab85e61bcadceb18

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 5f48c46
Pull Request: 3f67c17
Server: e35d0a082d820a88d1332d84b705581d43a5cb2f

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 5f48c46
Pull Request: 8943c09
Server: 35a4a7f6c9e79a5646dfe7e8d011fb1b7d3c88b2

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 3a4bbbf
Pull Request: d688fcd
Server: fc7857bd7fe55e551c08f7a8fdd2cd7e13cc9424

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: bf82990
Pull Request: d688fcd
Server: 6460a6ef15ecaab0beff69c3ce796e37242f1a8e

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: bf82990
Pull Request: d688fcd
Server: 37d2c53a8ac5a1f9216f01cc1878ff5594b33e0a

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: bf82990
Pull Request: d688fcd
Server: 2ad9c3c8d3df7ed8035fac0dffc06b9e1da07f1f

@EgorDinamit
Copy link

You turned what was meant to be an "Emergency Storage Pod" into a full base? Man, whenever I look what has happened to my silly ship on other servers it gets bigger and bigger. Keep it up.

@MysteryMan21333
Copy link
Author

Apologies gals and lads, I have to close the PR, something is going on with the integration tests, believe either a upstream crash, local issue with the repo, or something else. This PR will be back after I import it to a fresh instance and reupload, stay tuned!!!

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants