Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A workaround to fix loadout masks getting removed due Bane Syndrome quirk #969

Merged

Conversation

NopemanMcHalt
Copy link

@NopemanMcHalt NopemanMcHalt commented Oct 4, 2023

About The Pull Request

Due H.equip_to_slot forces aesthetic gas mask onto mask slot, it also removes loadout mask. This PR fixes the issue by using H.equip_to_slot_if_possible instead for the quirk, making the aesthetic drop onto floor while character get their mask of choice.

Also, sorry K4rlox, but I changed your file to have proper indentation.

Why It's Good For The Game

Bane/Gasmask Mooks will no longer suffer for being forced to wear aesthetic gasmask, even when they pick the liberated one from the loadout.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑 Anonymous
fix: Fixes Bane Syndrome quirk overwriting loadout's masks. Now the mask from the quirk will be dropped onto floor if you use loadout one.
/:cl:

Also corrects indentation for gasmask loadout change. Sorry K4rlox.
@MosleyTheMalO MosleyTheMalO merged commit ce3d2af into SPLURT-Station:master Oct 5, 2023
github-actions bot pushed a commit that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants