[TEST MERGE] Smart Cables #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Merge Removed |
|
Im closing this pull request, due to a few issues that have arisen with it and the general negative overview of smart cables I will most likely not work further on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Alright, I think we all know what smart cables are, however, for those who may not know here's a brief explanation. Smart Cables are used primarily by TG servers such as main TG, Skyrat, and TGMC due to the extent of how burdensome "Regular Cables" can be, so instead of placing two wires to create a single tile of wiring, you just need to place one wire down now and it can link to any nearby cabling, automatically connecting and creating a electrical grid with ease. This also will hopefully help with some of the performance issues on the server due to the amount of cables present connecting all systems.
Side Note: There will need to be a few tweaks to maps in the future as I don't believe I was able to remove all the duplicate wires spread through out the maps due to the sheer size. If you see some misplaced wires please leave a report in the issues tab on discord.
Why It's Good For The Game
Cleans up the wire count for the server, reduces lag, and provides a simpler method of wiring for both crew/mappers.
A Port?
Smart Cables
tgstation/tgstation#44265
Smart Cable Fixs
tgstation/tgstation#44784
Properly Fixs Smart Cables...
tgstation/tgstation#44945
Refactors Shield Wall Gen
tgstation/tgstation#45221
Fixs Grilles...
tgstation/tgstation#45318
Smart Cable Icon Tweaks
tgstation/tgstation#45319
Fixes Cables not being pulled...
tgstation/tgstation#45346
Fixes Cables propgate logic...
tgstation/tgstation#45351
Cleans up powernet...
tgstation/tgstation#45352
Fixs shield gen runtime
tgstation/tgstation#45402
Cable Layers
tgstation/tgstation#46761
Special Thanks to Spooky Donut,
tgstation/TerraGov-Marine-Corps#4114
Pre-Merge Checklist
Changelog
🆑
add: Smart Cables/Cable Layers.
qol: Cleaner mapping.
qol: Reduced Lag due to wiring.
/:cl: