Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Semi-Modular] Silicon Flavor Text #975

Conversation

MysteryMan21333
Copy link

@MysteryMan21333 MysteryMan21333 commented Oct 12, 2023

About The Pull Request

Good evening, I present to the fine people of this station a fix to the silicon flavor text issues on borgs. Meaning, you SHOULD be able to transfer your Silicon Flavor Text and OOC text to your cyborg characters! However, as a downside other players wont be able to see your preferences, I tried fixing it, I have no clue even after dedicating what appears to be 4-5 hours of my life in trying to trace down code and rework some areas. So it was either the preferences showing up or it was no OOC notes at all!

Screenshot 2023-10-11 063517

Screenshot 2023-10-11 063528

Screenshot 2023-10-11 183600

Why It's Good For The Game

We all know what this is for, Dogborg ERP 2023 edition! But on a serious note, alot of people were getting a bit agitated having to copy pasta their flavor text and OOC into their temporary texts which disappears after the round, now we don't have to deal with it!

A Port?

Silicon Flavor Text (#1928)
https://github.com/Skyrat-SS13/Skyrat-tg/pull/1928/files#diff-9e29fac756d308085f2f87b508af980fc7557caad973a1cff81099ef18219aeb

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
tweak: reverts I believe a previous PR additon from sandstorm/cit.
qol: reworks a tad bit of silicon text to function.
/:cl:

@MysteryMan21333 MysteryMan21333 deleted the Silicon-Flavor-Text branch May 16, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant