Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost Cafe Revamp [W.I.P] (don't merge please) #985

Closed
wants to merge 2 commits into from
Closed

Ghost Cafe Revamp [W.I.P] (don't merge please) #985

wants to merge 2 commits into from

Conversation

abit-slutty
Copy link

@abit-slutty abit-slutty commented Oct 26, 2023

About The Pull Request

Ghost Cafe Revamp, mostly just testing to see if I did this right, maintainers if I am attempting to merge the wrong thing let me know. (example: if I wasn't suppose to delete the map LOL)

Why It's Good For The Game

Current Cafe sucks, this one is cooler.

A Port?

Kind of, it's skyrats cafe ported to our codebase +- some tiles since we have different sprite names, couldn't find the skyrat PR but can edit this if someone can provide.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
add: new centcom map
del: old centcom map
note: it's the same map just with cafe deleted and new cafe added
/:cl:

@SmiLeYre
Copy link

Прикол.

@MosleyTheMalO
Copy link

Did you keep the vr spawners from our actual ghost cafe in the new one?

@Satile1
Copy link

Satile1 commented Oct 26, 2023

Here's a screenie of the PR's map -

Looks like the shuttle import marker got killed, probably need that back. Also what about the beach resort from Skyrat's current one! We can do cozier..

Skyrat's current beach

@abit-slutty
Copy link
Author

abit-slutty commented Oct 27, 2023

Did you keep the vr spawners from our actual ghost cafe in the new one?

This is still WIP, it's using our actual ghost cafe sleepers not anything else.
edited the PR title to express that sorry.

@abit-slutty
Copy link
Author

abit-slutty commented Oct 27, 2023

Here's a screenie of the PR's map -

Looks like the shuttle import marker got killed, probably need that back. Also what about the beach resort from Skyrat's current one! We can do cozier..

Skyrat's current beach

Thanks for the screenie, also NOOOOOO I PORTED THE WRONG MAP PART AAAAAAAAAAAAAAAAAAAAAAAAA, I'll add their current beach area in a bit, as for the shuttle import marker I'm going to need to know where it /was/ so I can avoid murdering it.

quick edit here, the cafe area I'm pulling from is this repo https://github.com/Skyrat-SS13/Skyrat13/blob/master/_maps/map_files/generic/CentCom_Skyrat.dmm which is.... outdated, but mostly because the newer skyrat TG repo can't be ported over at all, seeing as everything is under a completely separate name/datum, copying over anything even just the shape doesn't work properly, adding the extra beach area could be a future PR, I'd just rather a decent cafe for now over what we currently have.

@abit-slutty abit-slutty changed the title Ghost Cafe Revamp Ghost Cafe Revamp [W.I.P] (don't merge please) Oct 27, 2023
@abit-slutty abit-slutty closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants