[SEMI-MODULAR] [TEST MERGE] COMBAT REWORK PART ONE #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
What's with all the deletions of our modular shotguns in this file? also did you make sure our modular code works still?
There was a problem hiding this comment.
Double checking all modular code, but Im very sure itll function, in terms of shotgun deletions thats mainly due to it being reworked to a better form, removing code and replacing it with upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Good afternoon ladies and gentlemen, this is Part One of my rework of the current weapon systems. This is a attempt to get our systems to be up to date alongside TG. With this update I hope to use it as a stepping stone to continue building off of using PR s from Skyrat and TG to bring unique systems to our sadly out of date server.
Why It's Good For The Game
Updates our current code for the long process ahead.
A Port?
Hey revolver, don't mothers make good fathers? #41620
tgstation/tgstation#41620
I got guns #41804
tgstation/tgstation#41804
Yet more gun fixes #42722
tgstation/tgstation#42722
Makes unloading ballistic weapons better (Namely revolvers) #42837
tgstation/tgstation#42837
Ballistic guns autodoc #45578
tgstation/tgstation#45578
Gun sound revamp #46689
tgstation/tgstation#46689
Pre-Merge Checklist
Changelog
🆑
fix: fixs a snipers from bolting a round and perceiving it as non-existent.
soundadd: adds and reworks a bunch of firearm sounds.
sounddel: removes a bunch of firearm sounds.
refactor: refactors how some of the gun code functions, including new var.
qol: updates our code for more modern TG.
/:cl: