Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes some references to point at SPLURT #1

Merged
merged 5 commits into from
Jun 9, 2024
Merged

Conversation

MosleyTheMalO
Copy link

@MosleyTheMalO MosleyTheMalO commented Jun 9, 2024

About The Pull Request

As the title says, it changes some info related to names and whatnot so it directs to us

Why It's Good For The Game

Necessary

Proof Of Testing

It works

Changelog

🆑
code: Changes some info to reflect the station info
/:cl:

still a lot of stuff to fix
The skyrat html was already modular but uh... ok I guess?
@MosleyTheMalO MosleyTheMalO self-assigned this Jun 9, 2024
@MosleyTheMalO MosleyTheMalO merged commit e504dc8 into master Jun 9, 2024
24 of 25 checks passed
github-actions bot added a commit that referenced this pull request Jun 9, 2024
MosleyTheMalO pushed a commit that referenced this pull request Jun 29, 2024
* Update medical.dm

* Automatic changelog for PR #1 [ci skip]

* Delete html/changelogs/AutoChangeLog-pr-1.yml

* Update reagents.dm

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Useroth <[email protected]>
MosleyTheMalO pushed a commit that referenced this pull request Dec 7, 2024
…embeds on reagent spears (Bubberstation#2536)

## About The Pull Request
This fixes two bugs. Quoting the player reported bug:

Exploit #1 - Twitch Next Move modificier

This one needs a bit of VV to test mostly to speed up the conditions,
but its doable by a miner with a bit of skill.

You need the berserker armor of the chosen one, or alternatively, the
Dexterous mutation and a way to remove it (I think you can do so with
mutadone, but never tried, regardless!) and Twitch.
The short of it is that the next move variable is always edited with
multiplicatives, but Twitch was coded with an aditive, so alternating
one and another and then removing one effect and letting the other run
out would net you with a lower than 1 next move variable.

Exploit #2  - God Slaying Spear

This one is easy to test, basically you all got a spear with better
embeed stats than ninja stars, which embeeds most of the time thanks to
its high embeed chance, plus its armor penetration, with no chance for
it to fall out naturally so it has to be manually removed. Since it has
a Bulky weight class, its damage multiplier is 4 plus the pain
multiplier being 6, doing 24 damage per tick and on extraction, being
able to kill a person that gets it in 10 seconds, even if armored.

We had a whole clique abusing this as icecats on nova, and even
combining it with morphine.


https://github.com/Bubberstation/Bubberstation/blob/master/modular_skyrat/modules/reagent_forging/code/forge_weapons.dm#L136

## Why It's Good For The Game
Fixes some seriously game breaking bugs no one's abused yet, discovered
on Nova,

## Proof Of Testing

<details>
<summary>Screenshots/Videos</summary>

</details>

## Changelog

:cl: OrbisAnima (code for 1), ReturnToZender (code for 2)
fix: Fixes an exploit with Twitch, and the reagent forged spear's
embedding.
/:cl:

---------

Co-authored-by: Arturlang <[email protected]>
Krashly added a commit to Krashly/S.P.L.U.R.T-tg that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant