[MODULAR] adds intents #14
Conversation
There was a problem hiding this comment.
Just some small changes (mostly comments) I'd like to request for maintainability reasons. Code-wise, this looks good, though I'd also like it if it were documented somewhere what exactly the non-help/harm intents do now—in that disarm intent makes you do right-click interactions by default, and grab intent makes you do ctrl-click interactions. These things may be obvious to you (and me, after I looked over the code), but we want contributors to be able to get up to speed on the new codebase as fast as possible.
There was a problem hiding this comment.
I think we can ignore non-mob intent interactions right now; the two important things are that it works for swapping when moving (and it does, or at least should), and that it works for basic mob interactions like shoving and grabbing. This should also be a good foundation for things like the interactions menu, etc.
All that said, looks good to merge for further playtesting, given that you've already done some non-exhaustive local playtesting to rule out obvious issues.
# This is the 1st commit message: goofsec hud # This is the commit message #2: the sensible tgui errors # This is the commit message #3: Gets it to compile # This is the commit message #4: Fixes all extra runtimes # This is the commit message #5: TGUI Fixes 1 # This is the commit message #6: Removes open dream check # This is the commit message #7: Ticked file enforcement # This is the commit message #8: A very harsh way to fix potential missing icons # This is the commit message #9: Wipes all the errorneously included files # This is the commit message #10: fixes missing_icons fully # This is the commit message #11: some extra ci fixes before I forget # This is the commit message #12: WHAT THE FUCK # This is the commit message #13: really? # This is the commit message #14: bye waffles # This is the commit message #15: hooray
About The Pull Request
adds intents
needs heavy testing
Why It's Good For The Game
soul
Changelog
🆑
add: adds intents
/:cl: