Improvements to domain validation #17
Merged
+58
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsa33
requested review from
edwinbalani,
CMTC,
danielchriscarter and
eleanor-clifford
andyhhp
reviewed
Nov 16, 2024
smbz
reviewed
Nov 16, 2024
andyhhp
approved these changes
Nov 17, 2024
rsa33
force-pushed
the
domain-validation
branch
from
b535272
to
d14a52c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the creation of new domains when no DNS records are present for either of
$domainandwww.$domain.(Domains resolving to a different server are still permitted so that users can migrate to us without downtime.)
Add better validation for domain document roots: enforce being inside
public_html, block special characters that may interfere with macros, check the directory already exists, and fix non-canonical paths.Apply the docroot checks consistently across both adding and editing domains.