Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommandersAct should not send seek when pause #261

Closed
3 tasks done
StaehliJ opened this issue Oct 5, 2023 · 0 comments · Fixed by #268
Closed
3 tasks done

CommandersAct should not send seek when pause #261

StaehliJ opened this issue Oct 5, 2023 · 0 comments · Fixed by #268
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@StaehliJ
Copy link
Contributor

StaehliJ commented Oct 5, 2023

Context

As discussed with analytics team SRGSSR/pillarbox-documentation#26, Pillarbox apple doesn't send seek event when in pause, the web is implementing the same way.

So Android implementation have to follow the same behavior regarding seek event when player is paused.

As a user / integrator I don't want to see seek event when player is in pause state.

Acceptance criteria

  • CommandersAct streaming tracker doesn't send seek event when player is paused.

Tasks

  • Do not send seek event when player is paused
  • Do not send pause event after playing has seek when in paused.
  • Update tests
@StaehliJ StaehliJ converted this from a draft issue Oct 5, 2023
@StaehliJ StaehliJ added this to the Analytics milestone Oct 9, 2023
@StaehliJ StaehliJ moved this from ✏️ Draft to 📋 Backlog in Pillarbox Oct 9, 2023
@StaehliJ StaehliJ moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Oct 18, 2023
@StaehliJ StaehliJ self-assigned this Oct 18, 2023
@StaehliJ StaehliJ added the enhancement New feature or request label Oct 18, 2023
@StaehliJ StaehliJ linked a pull request Oct 18, 2023 that will close this issue
6 tasks
@StaehliJ StaehliJ moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Oct 19, 2023
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant