Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No seek event while in pause #268

Merged
merged 2 commits into from
Oct 20, 2023
Merged

No seek event while in pause #268

merged 2 commits into from
Oct 20, 2023

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Oct 18, 2023 •
edited
Loading

Pull request

Description

To align CommandersAct tracking with other Pillarbox platform. This PR modify the behaviors of seek event when the player is not playing.

Changes made

  • Don't send seek event to CommandersAct when playing is in pause state.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Oct 18, 2023 that may be closed by this pull request
CommandersAct should not send seek when pause #261
Closed
3 tasks
@StaehliJ StaehliJ requested a review from waliid October 18, 2023 08:00
@StaehliJ StaehliJ merged commit beda01c into main Oct 20, 2023
1 check passed
@StaehliJ StaehliJ deleted the 261-commanders-act-events-in-pause branch October 20, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CommandersAct should not send seek when pause
2 participants
@StaehliJ @waliid