Add localized error message. #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
defagos
reviewed
Sep 22, 2023
|
|
||
| override fun getErrorMessage(throwable: PlaybackException): Pair<Int, String> { | ||
| return when (val cause = throwable.cause) { | ||
| is BlockReasonException -> { | ||
| Pair.create(0, cause.blockReason.name) | ||
| val message = context.resources.getStringArray(R.array.blockReasonArray)[cause.blockReason.ordinal] |
There was a problem hiding this comment.
Fragile but you still decided to keep it anyway?
defagos
approved these changes
Sep 22, 2023
StaehliJ
force-pushed
the
249-improve-error-with-localized-message
branch
from
865d370 to
fbd7f26
Compare
Http error are currently not localized.
Throwable error are serialized by Media3 and need to have a constructor(message:String) in order to recreated the error.
The error is not the one we were testing. Uri always null because it can't be created here.
StaehliJ
force-pushed
the
249-improve-error-with-localized-message
branch
from
607c07d to
e5c8596
Compare
defagos
reviewed
Sep 25, 2023
...e-business/src/main/java/ch/srgssr/pillarbox/core/business/exception/BlockReasonException.kt
Outdated
Show resolved
Hide resolved
defagos
approved these changes
Sep 25, 2023
Co-authored-by: Samuel Défago <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Add localized block reason error message. Make also core business exceptions usable with Media3 and especially when using
MediaControllerorMediaBrowser.Changes made
SRGErrorMessageProviderprovide localized error messages.Checklist
mainbranch.