Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix player stops when next urn item fails to load. #251

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix player stops when next urn item fails to load. #251

merged 1 commit into from
Sep 22, 2023

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Sep 21, 2023 •
edited
Loading

Pull request

Description

This PR fix an issue when playing a short item followed by fail item stops the playback. The player goes in error for the next item even while not finishing playing the current item.

Changes made

Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ self-assigned this Sep 21, 2023
@StaehliJ StaehliJ merged commit f12be0d into main Sep 22, 2023
@StaehliJ StaehliJ deleted the fix-playlist-containing-urn-error branch September 22, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees

@StaehliJ StaehliJ

Labels
None yet
Projects
Pillarbox
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StaehliJ @defagos