259 compose toggleable view for tv and mobile #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
defagos
reviewed
Oct 6, 2023
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/SimplePlayerView.kt
Outdated
Show resolved
Hide resolved
defagos
approved these changes
Oct 6, 2023
pillarbox-ui/src/main/java/ch/srgssr/pillarbox/ui/layout/ToggleableBox.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Samuel Défago <[email protected]>
rts-devops
reviewed
Oct 6, 2023
| val interactionSource = remember { | ||
| MutableInteractionSource() | ||
| } | ||
| val isDragged = interactionSource.collectIsDraggedAsState().value |
There was a problem hiding this comment.
Private property isDragged is unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to provide to the integrators some usefull helpers and composable to handle toggleable content. For example to create a toggleable player controls.
Changes made
DelayedVisibilityState.ToggleableBoxthat handle interactions with touch and key event.Checklist
mainbranch.