Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

263 improve demo with some polish #266

Merged
merged 29 commits into from
Oct 17, 2023
Merged

263 improve demo with some polish #266

merged 29 commits into from
Oct 17, 2023

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

Improve the look of the demo and add some ui improvements.

Changes made

  • Self-explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

StaehliJ added 28 commits October 6, 2023 15:50
@StaehliJ
Remove depreciated accompanist systemUiController
5b2f461
@StaehliJ
update dependancies and compose to 1.5.3
1a3f6b3
@StaehliJ
Change bottom navigation bar icons
6693676
@StaehliJ
Improve playlist with player view in landscape
e98ade6
@StaehliJ
Improve PlaylistView
1d0ffb4
@StaehliJ
Improve playlist item view
c06c74f
@StaehliJ
Add more options for playlist add items
625a985
@StaehliJ
Improve playlist add item selector
cc4ceff
@StaehliJ
Improve playlist view alignement and space
90d0b0f
@StaehliJ
Remove duplicate playlist item
cb1aaab
@StaehliJ
Typo
b56128d
@StaehliJ
Add demo items
d85e586
@StaehliJ
Make debug information more pretty
f6543a1
@StaehliJ
Add some top padding for header
00fcb4f
@StaehliJ
Use same layout in showcases
edea59e
@StaehliJ
Add padding to search view
a3c9b66
@StaehliJ
Improve landscape for toggle tracker showcase
7a402d0
@StaehliJ
Remove ScaleMode.Zoom that doesn't nothing more that Crop
ca5e75d
@StaehliJ
Surface2 that handle aspect ratio differently
98ce5ee
@StaehliJ
Reorder package inside pillarbox-ui
e943091
@StaehliJ
Remove old SurfaceView
9ed1d16
@StaehliJ
Remove unused remaining view
38ce9b1
@StaehliJ
Simplify demo player
52c1da4
@StaehliJ
Add page indicator to story showcase
b36fba3
@StaehliJ
Bottom navigation bar always displayed
764a466
@StaehliJ
Close activity when user dismiss picture in picture
5eca0bf
@StaehliJ
Use Icon to handle dark mode
6a15330
@StaehliJ
Add controls to toggle tracking showcase
0b54714
@StaehliJ StaehliJ linked an issue Oct 17, 2023 that may be closed by this pull request
Improve Demo with some "polish" #263
Closed
11 tasks
@StaehliJ StaehliJ merged commit 003427a into main Oct 17, 2023
4 checks passed
@StaehliJ StaehliJ deleted the 263-improve-demo-with-some-polish branch October 17, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rts-devops rts-devops rts-devops left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Demo with some "polish"
2 participants
@StaehliJ @rts-devops