Send pause when no surface is connected to player #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to update
ComScoreTracker
to handle background state correctly. We have to send a pause event when the video is not visible by the user and send a play event with the new position when video is visible again.Solution
We assume that a player with no surface size is a player with no surface attached to it and so actually not visible by the user.
Changes made
Checklist
main
branch.