Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send pause when no surface is connected to player #267

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Oct 17, 2023

Pull request

Description

The goal of this PR is to update ComScoreTracker to handle background state correctly. We have to send a pause event when the video is not visible by the user and send a play event with the new position when video is visible again.

Solution

We assume that a player with no surface size is a player with no surface attached to it and so actually not visible by the user.

Changes made

  • Improve background / foreground video tracking for ComScore.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Oct 17, 2023 that may be closed by this pull request
2 tasks
@StaehliJ StaehliJ requested a review from defagos October 18, 2023 07:59
@StaehliJ StaehliJ force-pushed the comScore-background-playback branch from 6f9326d to c5ad5cb Compare October 20, 2023 09:56
@StaehliJ StaehliJ merged commit 9cbab6d into main Oct 20, 2023
4 checks passed
@StaehliJ StaehliJ deleted the comScore-background-playback branch October 20, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComScore video background
2 participants