Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BU selector in search view #286

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

MGaetan89
Copy link
Member

Pull request

Description

Previously, the selection of the BU was only available once we received some results from the backend (ie. the user had to enter at least 3 characters).
Now the BU selector is displayed above the search bar, visible by default, and it hides when we scroll in the search results.

Changes made

  • Move the BU selector out of the search results, above the search bar
  • Make the BU selector horizontally scrollable
  • Hide the BU selector when scrolling down, and show it when scrolling up

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 3, 2023 that may be closed by this pull request
2 tasks
@StaehliJ StaehliJ merged commit 09e14c6 into main Nov 3, 2023
4 checks passed
@StaehliJ StaehliJ deleted the 277-demo-search-improve-bu-selector branch November 3, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo search improve bu selector
2 participants