Add a navigation bar in the TV demo app #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defagos
approved these changes
Nov 8, 2023
| @@ -1,8 +1,8 @@ | |||
| /* | |||
| * Copyright (c) 2022. SRG SSR. All rights reserved. | |||
| * Copyright (c) 2023. SRG SSR. All rights reserved. | |||
There was a problem hiding this comment.
Recommendation: Remove dates from copyright info. Does not add any meaningful information and requires updates. Here is e.g. the header we have in Pillarbox Apple codebase:
//
// Copyright (c) SRG SSR. All rights reserved.
//
// License information is available from the LICENSE file.
//There was a problem hiding this comment.
I've created #295 for this, so we can change all copyright info at once
pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/TVDemoNavigation.kt
Outdated
Show resolved
Hide resolved
…/TVDemoNavigation.kt Co-authored-by: Samuel Défago <[email protected]>
MGaetan89
deleted the
292-add-navigation-bar-to-switch-between-examples-and-lists
branch
This was referenced Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The demo app on TV only supports the "Examples" section for now. The goal of #273 is to also add the "Lists" on that demo.
As a first step, I've added a navigation bar at the top of the app, to navigate between the "Examples" and "Lists" section.
Changes made
Checklist
mainbranch.