Create first levels in "Lists" #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
force-pushed
the
293-create-lists-section
branch
from
6f63a92 to
61f697c
Compare
waliid
approved these changes
Nov 14, 2023
Comment on lines
+110
to
+124
| composable( | ||
| route = ContentList.TvTopics.route, | ||
| arguments = listOf( | ||
| navArgument("bu") { type = NavType.StringType } | ||
| ) | ||
| ) { | ||
| val contentList = ContentList.TvTopics.parse(it) | ||
|
|
||
| BackHandler { | ||
| navController.popBackStack() | ||
| } | ||
|
|
||
| // TODO Integrate content (https://github.com/SRGSSR/pillarbox-android/issues/298) | ||
| Text(text = contentList.toString()) | ||
| } |
There was a problem hiding this comment.
I notice that this code is used multiple times. Can we factorize it in some way?
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to add the first two levels of navigations in the "Lists" section of the demo app for TV:
Video
Screen_recording_20231113_125515.webm
Changes made
Checklist
mainbranch.