Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation in the TV demo app #310

Merged
merged 16 commits into from
Nov 16, 2023

Conversation

MGaetan89
Copy link
Member

Pull request

Description

There was some issues when navigating in the TV demo app:

  • When in "Lists", it was hard to give the focus back to the top navigation to navigate to an other section
  • When in "Lists", pressing back would show the "Examples" section, but the top navigation would still show "Lists" as selected

Changes made

  • Observe navigation changes on root screens to update the top navigation accordingly
  • Migrate Compose previews to PillarboxTheme instead of using the default MaterialTheme
  • Observe press on the up arrow to give focus to the top navigation when needed

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 16, 2023 that may be closed by this pull request
Base automatically changed from 307-display-images-in-demo-tv to main November 16, 2023 15:28
@MGaetan89 MGaetan89 merged commit 1480acd into main Nov 16, 2023
4 checks passed
@MGaetan89 MGaetan89 deleted the 309-fix-top-navigation-in-the-tv-demo branch November 16, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix top navigation in the TV demo
2 participants