Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search results view #331

Merged

Conversation

MGaetan89
Copy link
Member

Move the BU selector inside the search input

Pull request

Description

This PR updates the layout of the search results to match what has been done in the other sections of the app.
It also moves the BU selector inside the search input, as it is done in pillarbox-web.

Changes made

  • Put the search results inside a card
  • Move the BU selector inside the search input

Screenshots

Description Light mode Dark mode
No content Screenshot_20231121_165451 Screenshot_20231121_165511
BU selector Screenshot_20231121_165456 Screenshot_20231121_165514
Results Screenshot_20231121_165505 Screenshot_20231121_165522

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 21, 2023 that may be closed by this pull request
Add a check next to the selected BU
@MGaetan89 MGaetan89 merged commit 9591d5f into main Nov 21, 2023
4 checks passed
@MGaetan89 MGaetan89 deleted the 304-align-search-results-with-pillarbox-apple-and-pillarbox-web branch November 21, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align search results with pillarbox-apple and pillarbox-web
2 participants