Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to pillarbox-player #430

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Add tests to pillarbox-player #430

merged 2 commits into from
Jan 30, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jan 30, 2024 •
edited
Loading

Pull request

Description

This PR adds new tests to the extension package of the pillarbox-player module. More PRs will come for the rest of the code.

Changes made

Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jan 30, 2024 that may be closed by this pull request
Update code coverage of pillarbox-player #425
Closed
@MGaetan89 MGaetan89 removed a link to an issue Jan 30, 2024
Update code coverage of pillarbox-player #425
Closed
@MGaetan89 MGaetan89 linked an issue Jan 30, 2024 that may be closed by this pull request
Update code coverage of pillarbox-player #425
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

Code Coverage

Overall Project 33.22% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-core-business 46.22% 🟢
:pillarbox-player 44.08% 🟢
Files
Module File Coverage
:pillarbox-core-business TotalPlaytimeCounter.kt 100% 🟢
:pillarbox-player Format.kt 100% 🟢
Player.kt 100% 🟢
PlayerCommands.kt 0% 🟢

@MGaetan89 MGaetan89 enabled auto-merge January 30, 2024 12:50
@MGaetan89 MGaetan89 force-pushed the 425-update-code-coverage-of-pillarbox-player branch from be8cde5 to d3c475c Compare January 30, 2024 16:08
@MGaetan89 MGaetan89 added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 38edd90 Jan 30, 2024
8 checks passed
@MGaetan89 MGaetan89 deleted the 425-update-code-coverage-of-pillarbox-player branch January 30, 2024 16:53
@MGaetan89 MGaetan89 mentioned this pull request Jan 31, 2024
Merged
6 tasks
MGaetan89 added a commit that referenced this pull request Jan 31, 2024
@MGaetan89
Add tests to pillarbox-player (#430)
5f1dd6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update code coverage of pillarbox-player
2 participants
@MGaetan89 @StaehliJ