Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

436 remove error handling from playersurface #437

Merged
merged 3 commits into from
Feb 5, 2024
Merged

436 remove error handling from playersurface #437

merged 3 commits into from
Feb 5, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Feb 5, 2024 •
edited
Loading

Pull request

Description

The goal of this PR is to remove error handling at the bottom level of the composable player surface view.

Changes made

  • Player surface doesn't handle error.
  • Make internal composable AndroidPlayerSurfaceView.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

Code Coverage

Overall Project 20.78% -0.58% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-ui 0% -2.04% 🟢
Files
Module File Coverage
:pillarbox-ui SphericalSurface.kt 0% 🟢
PlayerSurface.kt 0% -16.15% 🟢

@StaehliJ StaehliJ enabled auto-merge February 5, 2024 09:10
@StaehliJ StaehliJ added this pull request to the merge queue Feb 5, 2024
@MGaetan89 MGaetan89 linked an issue Feb 5, 2024 that may be closed by this pull request
Remove error handling from PlayerSurface #436
Closed
1 task
Merged via the queue into main with commit bcce330 Feb 5, 2024
8 checks passed
@StaehliJ StaehliJ deleted the 436-remove-error-handling-from-playersurface branch February 5, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove error handling from PlayerSurface
2 participants
@StaehliJ @MGaetan89