Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests between the player and the analytics #441

Merged
merged 13 commits into from
Feb 21, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Feb 13, 2024

Pull request

Description

This PR adds new tests to the Player, to validate how ComScoreTracker and CommandersActTracker reacts to player state change.

Changes made

  • Add new tests
  • Add constructors dedicated to ease testing
  • Make Gradle Wrapper distribution compatible with merge group

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Feb 13, 2024 that may be closed by this pull request
1 task
@MGaetan89 MGaetan89 changed the title A integration tests between the player and the analytics Add integration tests between the player and the analytics Feb 14, 2024
@MGaetan89 MGaetan89 force-pushed the 415-find-a-way-to-easily-test-player branch 2 times, most recently from 9a82d25 to ba2fafa Compare February 14, 2024 13:30
Copy link

github-actions bot commented Feb 14, 2024

Code Coverage

Overall Project 45.93% -0.04% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-core-business 66.52% -0.15% 🟢
:pillarbox-player 62.52% 🟢
Files
Module File Coverage
:pillarbox-core-business DefaultPillarbox.kt 0% -9.09% 🟢
:pillarbox-player MediaItemTracker.kt 100% 🟢
MediaItem.kt 84.62% 🟢
PillarboxPlayer.kt 46.69% 🟢

@MGaetan89 MGaetan89 force-pushed the 415-find-a-way-to-easily-test-player branch 3 times, most recently from 03aabac to 4643aef Compare February 15, 2024 13:31
@MGaetan89 MGaetan89 marked this pull request as ready for review February 16, 2024 14:30
@MGaetan89 MGaetan89 force-pushed the 415-find-a-way-to-easily-test-player branch 2 times, most recently from d9e0935 to 5a101db Compare February 19, 2024 08:30
@MGaetan89 MGaetan89 force-pushed the 415-find-a-way-to-easily-test-player branch from 5a101db to 616521e Compare February 20, 2024 14:15
@StaehliJ StaehliJ added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 82c7b39 Feb 21, 2024
9 checks passed
@StaehliJ StaehliJ deleted the 415-find-a-way-to-easily-test-player branch February 21, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find a way to easily test Player
2 participants