-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #453
Merged
Merged
Update dependencies #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
Files
|
MGaetan89
force-pushed
the
update_dependencies
branch
from
February 23, 2024 18:06
c63618d
to
c25f843
Compare
StaehliJ
approved these changes
Feb 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 26, 2024
MGaetan89
force-pushed
the
update_dependencies
branch
from
March 1, 2024 09:04
c25f843
to
473d2a3
Compare
MGaetan89
force-pushed
the
update_dependencies
branch
from
March 1, 2024 15:59
84ffe65
to
ba24404
Compare
StaehliJ
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When playing a Live DVR content after 30 seconds application crashes. It is due to wrong thread access. When checking if player is playing inside the async task.
Log :
FATAL EXCEPTION: DefaultDispatcher-worker-3
Process: ch.srgssr.pillarbox.demo.debug, PID: 20911
java.lang.IllegalStateException: Player is accessed on the wrong thread.
Current thread: 'DefaultDispatcher-worker-3'
Expected thread: 'main'
See https://developer.android.com/guide/topics/media/issues/player-accessed-on-wrong-thread
at androidx.media3.exoplayer.ExoPlayerImpl.verifyApplicationThread(ExoPlayerImpl.java:2842)
at androidx.media3.exoplayer.ExoPlayerImpl.getPlayWhenReady(ExoPlayerImpl.java:830)
at ch.srgssr.pillarbox.player.PillarboxPlayer.getPlayWhenReady(Unknown Source:2)
at ch.srgssr.pillarbox.core.business.tracker.commandersact.CommandersActStreaming$periodicTask$2.invokeSuspend(CommandersActStreaming.kt:78)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:585)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:802)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:706)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:693)
Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [CoroutineName(pillarbox-heart-beat), StandaloneCoroutine{Cancelling}@5cf315e, Dispatchers.Default]
StaehliJ
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR updates the dependencies of the project to the latest version.
Changes made
actions/checkout
v4actions/setup-java
v4gradle/wrapper-validation-action
v2Checklist
main
branch.