Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #453

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Update dependencies #453

merged 10 commits into from
Mar 5, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Feb 23, 2024

Pull request

Description

This PR updates the dependencies of the project to the latest version.

Changes made

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 added the enhancement New feature or request label Feb 23, 2024
@MGaetan89 MGaetan89 added this to the 1.0.0 milestone Feb 23, 2024
Copy link

github-actions bot commented Feb 23, 2024

Code Coverage

Overall Project 53.34% -0.06% 🟢
Files changed 96.63% 🟢

Module Coverage
:pillarbox-core-business 83.84% -0.21% 🟢
Files
Module File Coverage
:pillarbox-core-business CommandersActStreaming.kt 96.43% 🟢
CommandersActTracker.kt 96.39% 🟢
DefaultMediaItemTrackerRepository.kt 80.77% -17.31% 🟢

@MGaetan89 MGaetan89 self-assigned this Feb 23, 2024
@StaehliJ StaehliJ added this pull request to the merge queue Feb 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2024
@MGaetan89 MGaetan89 force-pushed the update_dependencies branch from c25f843 to 473d2a3 Compare March 1, 2024 09:04
@MGaetan89 MGaetan89 force-pushed the update_dependencies branch from 84ffe65 to ba24404 Compare March 1, 2024 15:59
Copy link
Contributor

@StaehliJ StaehliJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When playing a Live DVR content after 30 seconds application crashes. It is due to wrong thread access. When checking if player is playing inside the async task.

Log :

FATAL EXCEPTION: DefaultDispatcher-worker-3
                 Process: ch.srgssr.pillarbox.demo.debug, PID: 20911
                 java.lang.IllegalStateException: Player is accessed on the wrong thread.
                 Current thread: 'DefaultDispatcher-worker-3'
                 Expected thread: 'main'
                 See https://developer.android.com/guide/topics/media/issues/player-accessed-on-wrong-thread
                 	at androidx.media3.exoplayer.ExoPlayerImpl.verifyApplicationThread(ExoPlayerImpl.java:2842)
                 	at androidx.media3.exoplayer.ExoPlayerImpl.getPlayWhenReady(ExoPlayerImpl.java:830)
                 	at ch.srgssr.pillarbox.player.PillarboxPlayer.getPlayWhenReady(Unknown Source:2)
                 	at ch.srgssr.pillarbox.core.business.tracker.commandersact.CommandersActStreaming$periodicTask$2.invokeSuspend(CommandersActStreaming.kt:78)
                 	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
                 	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
                 	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:585)
                 	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:802)
                 	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:706)
                 	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:693)
                 	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [CoroutineName(pillarbox-heart-beat), StandaloneCoroutine{Cancelling}@5cf315e, Dispatchers.Default]

@StaehliJ StaehliJ enabled auto-merge March 5, 2024 08:59
@StaehliJ StaehliJ added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit c141f24 Mar 5, 2024
9 checks passed
@StaehliJ StaehliJ deleted the update_dependencies branch March 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants