Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version regex and add tests #611

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jun 27, 2024

Pull request

Description

This PR updates the regex used to validate the version of the library.

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jun 27, 2024 that may be closed by this pull request
1 task
Copy link

github-actions bot commented Jun 27, 2024

Code Coverage

Overall Project 48.97% -0.13% 🟢
Files changed 44.23% 🟢

Module Coverage
Kover Gradle Plugin XML report for :plugins 9.19% -2.75% 🟢
Files
Module File Coverage
Kover Gradle Plugin XML report for :plugins VersionConfig.kt 100% 🟢
PillarboxAndroidApplicationPlugin.kt 0% -9.36% 🟢
PillarboxAndroidLibraryPublishingPlugin.kt 0% -3.12% 🟢

@MGaetan89 MGaetan89 marked this pull request as draft June 27, 2024 08:45
@MGaetan89
Copy link
Member Author

I'll check the workflow regex on my fork before we can merge this.

@MGaetan89 MGaetan89 marked this pull request as ready for review June 27, 2024 09:00
@MGaetan89
Copy link
Member Author

The PR status points to the wrong PR.
This PR builds successfully, as it can be seen here.

@MGaetan89 MGaetan89 requested a review from StaehliJ June 28, 2024 11:56
@MGaetan89 MGaetan89 closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Pillarbox regex for version validation is too permissive
1 participant