Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check device capabilities to display picture in picture button #663

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Check device capabilities to display picture in picture button #663

merged 2 commits into from
Jul 31, 2024

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

We should check if the device is capable of enable Picture-in-Picture as recommanded by Google.

https://source.android.com/docs/core/display/pip#device-requirements

Changes made

  • Self-explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

Code Coverage

Overall Project 48.96% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 added the bug Something isn't working label Jul 30, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 883bc6f Jul 31, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the fix-picture-in-picture-android-7 branch July 31, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees

@StaehliJ StaehliJ

Labels
bug Something isn't working
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StaehliJ @MGaetan89