Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display metrics overlay in the TV demo and add a dedicated setting #666

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jul 30, 2024

Pull request

Description

This PR adds a new playback setting to enable or disable the metrics overlay. It also displays the metrics overlay based on that setting. I didn't add the text color and size settings, as we did on the mobile demo, but used the yellow text color and medium text size instead.

Changes made

  • Add a playback setting in pillarbox-demo-tv to enable/disable the metrics overlay.
  • Display the metrics overlay if the corresponding setting is enabled.
  • Move MetricsOverlay to pillarbox-demo-shared.
  • Add a shadow on the text of the MetricsOverlay to improve readability.
  • Change the metrics overlay text size to 12sp, 14sp, 16sp to match Material's body small, body medium, and body large text sizes respectively. Let me know if you prefer to keep the original values.

Screenshots

Description  Screenshot
Metrics overlay setting disabled  Screenshot_20240730_145524
Metrics overlay setting enabled Screenshot_20240730_145438
Metrics overlay displayed with controls visible Screenshot_20240730_145448
Metrics overlay displayed with controls hidden Screenshot_20240730_145453

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jul 30, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 30, 2024

Code Coverage

Overall Project 53.52% 🟢

There is no coverage information present for the Files changed

@StaehliJ StaehliJ merged commit 285fa8e into qos Aug 12, 2024
10 checks passed
@StaehliJ StaehliJ deleted the 662-add-metrics-overlay-in-the-tv-demo-app branch August 12, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add metrics overlay in the TV demo app
2 participants