-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display metrics overlay in the TV demo and add a dedicated setting #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/player/compose/PlayerView.kt
Fixed
Show fixed
Hide fixed
Code Coverage
|
StaehliJ
reviewed
Aug 12, 2024
pillarbox-demo-shared/src/main/java/ch/srgssr/pillarbox/demo/shared/ui/settings/AppSettings.kt
Outdated
Show resolved
Hide resolved
StaehliJ
approved these changes
Aug 12, 2024
MGaetan89
added a commit
that referenced
this pull request
Aug 12, 2024
MGaetan89
added a commit
that referenced
this pull request
Aug 13, 2024
MGaetan89
added a commit
that referenced
this pull request
Aug 20, 2024
StaehliJ
pushed a commit
that referenced
this pull request
Aug 28, 2024
StaehliJ
pushed a commit
that referenced
this pull request
Sep 11, 2024
MGaetan89
added a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR adds a new playback setting to enable or disable the metrics overlay. It also displays the metrics overlay based on that setting. I didn't add the text color and size settings, as we did on the mobile demo, but used the yellow text color and medium text size instead.
Changes made
pillarbox-demo-tv
to enable/disable the metrics overlay.MetricsOverlay
topillarbox-demo-shared
.MetricsOverlay
to improve readability.Screenshots
Checklist
main
branch.