-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to AndroidX Media3 1.5.0 #794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
Files
|
e8bd7f9
to
eda06c6
Compare
Moved to the backlog until the next release of AndroidX Media3 1.5.0 |
eda06c6
to
362e09a
Compare
362e09a
to
ff49dad
Compare
2 tasks
a81e0e9
to
1f2df47
Compare
StaehliJ
approved these changes
Nov 26, 2024
MGaetan89
commented
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@StaehliJ I've just moved the PreloadConfiguration
to the root package, so it's in the same location as the other similar functions (PillarboxBandwidthMeter
, PillarboxRenderersFactory
, ...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Update the AndroidX Media3 dependency to 1.5.0.
The release notes are available here.
Changes made
DefaultPreloadManager.Status.STAGE_LOADED_TO_POSITION_MS
constant in favor ofDefaultPreloadManager.Status.STAGE_LOADED_FOR_DURATION_MS
.PillarboxLoadControl
to override the newonTracksSelected()
andshouldContinuePreloading
methods.PillarboxPreloadManager
to useDefaultPreloadManager.Builder
instead of the deprecatedDefaultPreloadManager
constructor.C.ROLE_FLAG_AUXILIARY
inFormat.roleString()
PillarboxMediaController
to remove removed methods.Checklist