Make some symbols internal
/private
#800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR changes the visibility of some symbols in
pillarbox-player
so they are not exposed unnecessarily to integrators.This will also help limit the amount of data that we show to integrators in the documentation.
Changes made
PillarboxBuilder.create()
internal: this method creates aPillarboxExoPlayer
, whose constructor is already internal. Everything needed by this method can be customized via methods onPillarboxBuilder
.PillarboxAnalyticsListener
andPlaybackSessionManager.Listener
implementations inner classes inMetricsCollector
: there's no need to expose these, since they are only needed inside ofMetricsCollector
.MakeList<TimeRange>.firstOrNullAtPosition(position: Long)
internal: seems rather specific to our needs. But I'm open to reverting this.MonitoringConfigFactory
's constructor internal: it is only necessary insidePillarboxBuilder
to create the DSL structure.Open points
There are other symbols that may be removed/internalized. Tell me what you think about them:
Format.selectionString()
: seems more like a debug method. I think we can remove it.Format.roleString()
: same as above.BitrateUtil
: only used in the demo. I suggest moving it there.StringUtil
: seems more like a debug class. Maybe we can internalize it or remove it.KeepScreenOn
: only used in the demo. What about moving it there?Checklist