Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions workflows #818

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Nov 27, 2024

Pull request

Description

This PR updates the GitHub Actions workflows.

Changes made

  • Merge the Dokka workflow into the release one. This way, the published API documentation always reflects the latest stable release of Pillarbox.
  • Only use Gradle's cache in the release workflow. It is discouraged to use Gradle's cache and actions/setup-java cache at the same time.
  • Make the cache read-only in the release workflow. Since it runs only once in a while, there's no benefit in storing any output from this workflow.
  • Add read-only cache support to the "Build on Windows" workflow. This may improve its build time without storing any additional data.
  • Make the cache read-only is the nightly workflow. Since it runs in the middle of the night, we don't care for the small performance boost provided by the cache, but we may gain some storage space.
  • Rename the "Build" workflow to "Quality", since it's doing more than just building the project.
  • Add missing names on some steps and align the naming between all workflows, for clarity:
Before After
Screenshot 2024-11-27 at 15 45 02 Screenshot 2024-11-27 at 15 45 33

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this Nov 27, 2024
@MGaetan89 MGaetan89 added the enhancement New feature or request label Nov 27, 2024
Copy link

Code Coverage

Overall Project 48.65% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 requested a review from StaehliJ November 27, 2024 14:46
Copy link
Contributor

@StaehliJ StaehliJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@StaehliJ StaehliJ added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit bd05b1d Nov 27, 2024
9 checks passed
@StaehliJ StaehliJ deleted the update_github_actions_workflows branch November 27, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants